add skipAssertUserNotAuthenticated option to signInWithRedirect #12584
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR allows you to call
signInWithRedirect
even when a user is already signed in. The use-case is that we have Google login and some customers want to enforce that their users only sign-in with Google. If a user logs in with their password we will show an error along with a button prompting them to sign-in via Google. With v5, you could callAuth.federatedSignIn
even when a user was already logged in. This allows you to similarly callsignInWithRedirect
.I'm 50/50 on the name, might want to do the inverse so a truthy value would allow you to skip the assertion.Edit: Decided to do the inverse instead.
Description of how you validated changes
Used
patch-package
with these changes.Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.