Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is domain property required? - CookieStorage Interface #6743

Open
doutori opened this issue Sep 8, 2020 · 1 comment
Open

Is domain property required? - CookieStorage Interface #6743

doutori opened this issue Sep 8, 2020 · 1 comment
Assignees
Labels
amazon-cognito-identity-js Used for issues related to this specific package within the monorepo Auth Related to Auth components/category feature-request Request a new feature

Comments

@doutori
Copy link

doutori commented Sep 8, 2020

Is your feature request related to a problem? Please describe.
Auth / Cognito with cookieStorage

CookieStorage interface is below.

interface ICookieStorageData {
	domain: string;
	path?: string;
	expires?: number;
	secure?: boolean;
	sameSite?: 'strict' | 'lax' | 'none';
}

throw new Error('The domain of cookieStorage can not be undefined.');

Is there a reason a domain property is required?
When we specify the domain of the cookie, it will be sent to the subdomain.
It's not secure.

Describe the solution you'd like
Cookie domain property should be Optional.

Describe alternatives you've considered

Additional context

@doutori doutori added the feature-request Request a new feature label Sep 8, 2020
@amhinson amhinson added the amazon-cognito-identity-js Used for issues related to this specific package within the monorepo label Oct 19, 2020
@abdallahshaban557 abdallahshaban557 added the Auth Related to Auth components/category label Jun 3, 2022
@alexan
Copy link

alexan commented Oct 7, 2022

is there a possibility to use cookie storage but not send the cookies to all subdomains?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
amazon-cognito-identity-js Used for issues related to this specific package within the monorepo Auth Related to Auth components/category feature-request Request a new feature
Projects
None yet
Development

No branches or pull requests

5 participants