Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[amazon-cognito-identity-js] check if native module is not undefined #5192

Open
tcodes0 opened this issue Mar 25, 2020 · 0 comments
Open

[amazon-cognito-identity-js] check if native module is not undefined #5192

tcodes0 opened this issue Mar 25, 2020 · 0 comments
Labels
amazon-cognito-identity-js Used for issues related to this specific package within the monorepo feature-request Request a new feature React Native React Native related issue

Comments

@tcodes0
Copy link

tcodes0 commented Mar 25, 2020 •
edited
Loading

Is your feature request related to a problem? Please describe.
using react-native, if the app is run without the native module built, it will result in an opaque error when attempting to do something

Describe the solution you'd like
Lib should throw immediately if native dependencie is falsey

Describe alternatives you've considered
I did debug and find this out

Additional context
react native, affects only amazon-cognito-identity-js
@tcodes0 tcodes0 added the feature-request Request a new feature label Mar 25, 2020
@tcodes0 tcodes0 changed the title [amazon-cognito-identity-js] check if native modulo is not undefined [amazon-cognito-identity-js] check if native module is not undefined Mar 25, 2020
@amhinson amhinson added amazon-cognito-identity-js Used for issues related to this specific package within the monorepo React Native React Native related issue labels Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
amazon-cognito-identity-js Used for issues related to this specific package within the monorepo feature-request Request a new feature React Native React Native related issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tcodes0 @amhinson