Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@aws-amplify/backend should inherit version bump kind from dependencies. #1693

Open
sobolk opened this issue Jun 27, 2024 · 0 comments
Open

@aws-amplify/backend should inherit version bump kind from dependencies. #1693

sobolk opened this issue Jun 27, 2024 · 0 comments
Labels
bug Something isn't working repo-infrastructure Engineering label for issues related to repo infrastructure tech-debt Refactors, unsavory workarounds or other technical decisions that should be revisited later

Comments

@sobolk
Copy link
Member

sobolk commented Jun 27, 2024

Follow up on top of #1637 .

We shipped @aws-amplify/backend-function@1.1.0 I.e. with minor version increment. But automatically @aws-amplify/backend received only patch increment and shipped with @aws-amplify/backend@1.0.4.

@aws-amplify/backend should inherit version bump kind from dependencies from which it re-exports APIs.

A minimal solution that would fulfill this ask is to implement PR check that fails if changesets are not correct in this respect.
@sobolk sobolk added bug Something isn't working tech-debt Refactors, unsavory workarounds or other technical decisions that should be revisited later p2 repo-infrastructure Engineering label for issues related to repo infrastructure labels Jun 27, 2024
@ykethan ykethan removed the p2 label Aug 27, 2024
@ShadowCat567 ShadowCat567 mentioned this issue Sep 23, 2024
Draft
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working repo-infrastructure Engineering label for issues related to repo infrastructure tech-debt Refactors, unsavory workarounds or other technical decisions that should be revisited later
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sobolk @ykethan