feat!: cleanup input handling #1445
Merged
+58
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kellertk
force-pushed
the
kellertk/input-boolean
branch
from
52f71c1 to
bdc3869
Compare
lehmanmj
approved these changes
Aug 20, 2025
kellertk
added a commit
that referenced
this pull request
Aug 20, 2025
Co-authored-by: Michael Lehmann <lehmanmj@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
feat!: Cleanup input handling. Changes invalid boolean input behavior (see #1445)
END_COMMIT_OVERRIDE
Changes boolean input handling. Now, unparseable values for boolean inputs throw an exception instead of defaulting to false. This should not be impacting unless you relied on invalid values for boolean inputs being coerced to false, as it was previously.