-
Notifications
You must be signed in to change notification settings - Fork 9
Types fix, useAsync hook + removing negation #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mytecor
wants to merge
6
commits into
awmleer:master
Choose a base branch
from
mytecor:patch-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
317a2a6
Types fix + removing negation
mytecor b9a1ccd
tabs
mytecor 1734a8c
feat: useAsync hook for restoring current value
mytecor 1aaf227
chore: factory args
mytecor d520683
fix(useAsync): forceUpdate ignored in some cases
mytecor 3197b3f
Merge branch 'awmleer:master' into patch-1
mytecor File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,19 +1,35 @@ | ||
import {DependencyList, useEffect, useState} from 'react' | ||
import { DependencyList, useRef, useEffect, useState, useReducer, useMemo } from 'react' | ||
|
||
export function useAsyncMemo<T>(factory: () => Promise<T>, deps?: DependencyList, initial?: T) { | ||
let [val, setVal] = useState(initial) | ||
|
||
export function useAsyncMemo<T>(factory: () => Promise<T> | undefined | null, deps: DependencyList, initial: T = undefined): T { | ||
const [val, setVal] = useState<T>(initial) | ||
useEffect(() => { | ||
let cancel = false | ||
const promise = factory() | ||
if (promise === undefined || promise === null) return | ||
promise.then((val) => { | ||
if (!cancel) { | ||
setVal(val) | ||
} | ||
}) | ||
let pending = true | ||
factory().then(res => pending && setVal(res)) | ||
|
||
return () => { | ||
cancel = true | ||
pending = false | ||
} | ||
}, deps) | ||
|
||
return val | ||
} | ||
|
||
export function useAsync<T>(factory: () => Promise<T>, deps?: DependencyList, initial?: T) { | ||
mytecor marked this conversation as resolved.
Show resolved
Hide resolved
|
||
let forceUpdate = useState<T>()[1] | ||
let val = useRef(initial) | ||
|
||
useMemo(() => val.current = initial, deps) | ||
useEffect(() => { | ||
let pending = true | ||
factory().then(res => { | ||
if(pending) | ||
forceUpdate(val.current = res) | ||
}) | ||
return () => { | ||
pending = false | ||
} | ||
}, deps) | ||
|
||
return val.current | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.