Explain more clearly that days of the month are not padded by default #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have improved the
README.mdfile to explain better that hours and days of the month are not padded by default. Since documentation uses 24th and there is a note about padding only for months, some users may think the rest of the components are padded automatically.In addition, I have added some unit tests to verify that the days of the month are properly padded in
index.spec.js. My initial intention was to avoid changes in the rest of the file, but I thought that keeping a single date for all the tests as you were doing was more appropriate, so I have changed the day of the month and updated the unit tests accordingly.By the way, thank you for this library; it is very useful for the projects I work on.