Migrate to PlatformIO #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major and very important upgrade of HyperSerialEsp8266. There are many reason that caused are migration from Arduino IDE to PlatformIO.
Refactoring was primarily caused by latest v19 beta1 release, that includes some changes making old 'First LED enabled/disabled' version firmware obsolete. You can read more about it here: awawa-dev/HyperHDR#379 and you can disable/enable first LED in HyperHDR v19.
Also all floating point operations used for RGBW calibration were removed and integer operations were used instead . A special unit test guards the correctness of the new RGBW calculations so the backward compatibility is preserved. All related variables were encapsulated into separated structures to make the code more readable.