implemented external LED power control #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed tab indentation
|
Added caching for digitalWrites because they are not completely for free. For esp32 (but not esp32-S2) the "handshake" option in HyperHDR resets the board and the relay pin immediately goes low. This can be undesirable if the LED driver is turned off/on in a short time without waiting for the 5 second timeout, so for esp32 (and esp32 only) you can disable "handshake" in Adalight's HyperHDR settings. "Continues output" in the smoothing should be rather used to counter turning off relay control for static colors, because enabling additional timer directly in LED driver could lead to some side effects and should be avoided. |
|
Thanks for the adjustments and the merge. It works like a charm :) Very nice work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This enhancement implementes a mechanism to power off the LED power source using an external pin.
The mechanism is triggered 5 seconds after no serial data is received.
This feature is mainly implemented due to power saving. 60 WS2815 RGB LEDs have an idle power consumption of 0.12A on 12V. Which is ~1.5W of power when they are not in use (only 12V active).
Tested
Potential issues
For static color light the refresh rate has to be non zero value. Otherwise no serial data will be transmitted and the LEDs will turn off.
Is this an issue with the configuration as the readme shows a refresh rate of 0?