some provider report missing feedback.version

[Cyrille37]

Hi

Thanks to share your work, it's so nice 💌

Some provider report format does not contains feedback.version like Yahoo :

<?xml version="1.0"?>	
<feedback>	
  <report_metadata>	
    <org_name>Yahoo</org_name>	
    <email>dmarchelp@yahooinc.com</email>	
    <report_id>1735694883.674529</report_id>	
    <date_range>	
      <begin>1735603200</begin>	
      <end>1735689599</end>	
    </date_range>	
  </report_metadata>	
...
</feedback>

that's throw a Saloon\XmlWrangler\Exceptions\MissingNodeException saying "Unable to find the [feedback.version] node" at $version = $reader->value('feedback.version')->sole();.

[Cyrille37]

Here is the full DMARC report because Yahoo format is missing many elements

<?xml version="1.0"?>	
<feedback>	
  <report_metadata>	
    <org_name>Yahoo</org_name>	
    <email>dmarchelp@yahooinc.com</email>	
    <report_id>1735694883.674529</report_id>	
    <date_range>	
      <begin>1735603200</begin>	
      <end>1735689599</end>	
    </date_range>	
  </report_metadata>	
  <policy_published>	
    <domain>listes.comptoir.net</domain>	
    <adkim>r</adkim>	
    <aspf>r</aspf>	
    <p>quarantine</p>	
    <pct>100</pct>	
  </policy_published>	
  <record>	
    <row>	
      <source_ip>49.12.227.144</source_ip>	
      <count>30</count>	
      <policy_evaluated>	
        <disposition>none</disposition>	
        <dkim>pass</dkim>	
        <spf>pass</spf>	
      </policy_evaluated>	
    </row>	
    <identifiers>	
      <header_from>listes.comptoir.net</header_from>	
    </identifiers>	
    <auth_results>	
      <dkim>	
        <domain>listes.comptoir.net</domain>	
        <selector>default</selector>	
        <result>pass</result>	
      </dkim>	
      <spf>	
        <domain>listes.comptoir.net</domain>	
        <result>pass</result>	
      </spf>	
    </auth_results>	
  </record>	
</feedback>	

[avvertix]

Ehi @Cyrille37 thanks for sharing the Yahoo report. Let me have a look at what other elements are missing to understand the impacts.

[Cyrille37]

I'm downloading 842 reports from my mailbox, I'll give you them in some minutes ...

[avvertix]

So far, based on the Yahoo report, there are few elements that apparently are optional which I didn't understood to be that way:

• version number
• envelope_from in identifiers
• sp and fo in policy
• scope in SpfAuthResult

Based on a first try I think making them nullable should work just fine. I'm including an anonymized version of the Yahoo report you shared as part of the test suite to confirm that missing elements are handled (see #5 )

[Cyrille37]

I'm try with hundred of reports and make some changes because of datum type or ValueError like :

final class PolicyOverrideReason
{
    public function __construct(
        public readonly PolicyOverrideType $type,
        public readonly ?string $comment = null,
    ) {}

    public static function fromArray(array|string $policy): self
    {
        if (is_array($policy))
            return new self(
                type: PolicyOverrideType::from($policy['type']),
                comment: $policy['comment'] ?? null,
            );

        try {
            return new self(
                type: PolicyOverrideType::from($policy),
                comment: null,
            );
        } catch (\ValueError $ex) {
            return new self(
                type: PolicyOverrideType::OTHER,
                comment: $policy,
            );
        }
    }
}

[avvertix]

Sometimes the value error is caused by the fact that the element is not present in the xml. Please run the code in #5 to see if those are caused by edge cases of optional elements.

[avvertix]

A test run of #5 confirmed that errors were triggered by missing elements and a bug in handling the reason, which was expected to be an array of array.

[Cyrille37]

Thanks

[Cyrille37]

You've published on packagist, great :-)

[Cyrille37]

Great 💌 ! I've just tested your last release v0.1.0, it works with all my DMARC reports. Thanks 😸