Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Set default to null when the field type is nullable (activable by the configuration) #140

Merged
merged 1 commit into from
Jun 16, 2023

Conversation

Chuckame
Copy link
Contributor

Quick PR that have no impact on the existing features. I hope you will release it before the work of primitives in root 🙏

@Chuckame Chuckame force-pushed the optional-nullable branch 2 times, most recently from 90b4cbb to b2d47f0 Compare May 29, 2023 13:13
Copy link
Member

@thake thake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR a really useful addition. It will certainly be merged before primitive types.

README.md Show resolved Hide resolved
@thake
Copy link
Member

thake commented May 31, 2023

@Chuckame, do you want to join me in maintaining this repo?

@Chuckame
Copy link
Contributor Author

@thake yes, why not!!

@Chuckame
Copy link
Contributor Author

Thanks for the PR a really useful addition. It will certainly be merged before primitive types.

Good idea, did you worked on it since the last commit to your primitives in root branch?

@thake
Copy link
Member

thake commented Jun 1, 2023

Thanks for the PR a really useful addition. It will certainly be merged before primitive types.

Good idea, did you worked on it since the last commit to your primitives in root branch?

No, not yet. If you want, you can give it a try.

@Chuckame
Copy link
Contributor Author

Chuckame commented Jun 1, 2023

Yes I begun something similar to Json, proto, and other native serializers. I would like to lighten the Avro class, make some extensions and make it more configurable (starting with this pr)

@Chuckame
Copy link
Contributor Author

Chuckame commented Jun 1, 2023

By the way, how do you want me to make releases? That way we add a CONTRIBUTING.md 😁

@thake
Copy link
Member

thake commented Jun 2, 2023

By the way, how do you want me to make releases? That way we add a CONTRIBUTING.md grin

I've opened up an issue #143 for that. Maybe we'll have to change something on the release workflow.

@thake
Copy link
Member

thake commented Jun 2, 2023

Yes I begun something similar to Json, proto, and other native serializers. I would like to lighten the Avro class, make some extensions and make it more configurable (starting with this pr)

That sounds really awesome :) Do you want to talk me through before? That way I can give you some input and work out a solution together. You can find my contact details on my github profile, I think we should discuss this "face to face".

@Chuckame
Copy link
Contributor Author

Chuckame commented Jun 7, 2023

@thake I also added a little comment on the config field inside the codebase. Ok to merge this and release it ?

@Chuckame Chuckame merged commit 4e8a384 into avro-kotlin:main Jun 16, 2023
@Chuckame Chuckame deleted the optional-nullable branch April 23, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants