Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplification: merge AvroJsonProp to AvroProp #201

Closed
Chuckame opened this issue Apr 30, 2024 · 1 comment · Fixed by #204
Closed

Simplification: merge AvroJsonProp to AvroProp #201

Chuckame opened this issue Apr 30, 2024 · 1 comment · Fixed by #204
Labels
enhancement New feature or request

Comments

@Chuckame
Copy link
Contributor

Currently, @AvroProp("text") is translated to a text node containing text. This is also the behavior of AvroJsonProp when it is not a valid json.

Let's unify AvroJsonProp and AvroProp to simplify the avro4k api, and now support json in AvroProp
@Chuckame Chuckame added the enhancement New feature or request label Apr 30, 2024
Chuckame added a commit to Chuckame/avro4k that referenced this issue May 3, 2024
@Chuckame
feat!: Merge AvroJsonProp to AvroProp avro-kotlin#201
7235037
Chuckame added a commit to Chuckame/avro4k that referenced this issue May 3, 2024
@Chuckame
feat!: Merge AvroJsonProp to AvroProp avro-kotlin#201
bb5b035
@Chuckame Chuckame mentioned this issue May 3, 2024
Merged
@Chuckame Chuckame linked a pull request May 3, 2024 that will close this issue
feat!: Merge AvroJsonProp to AvroProp #204
Merged
@Chuckame
Copy link
Contributor Author

Released in v2.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat!: Merge AvroJsonProp to AvroProp Chuckame/avro4k
1 participant
@Chuckame