Skip to content

Promise-ify nreplClient.ts. #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 26, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 12 additions & 14 deletions src/clojureDefinition.ts
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -14,20 +14,18 @@ export class ClojureDefinitionProvider implements vscode.DefinitionProvider {
if (!wordRange) if (!wordRange)
return Promise.reject('No word selected.'); return Promise.reject('No word selected.');


return new Promise((resolve, reject) => { const currentWord: string = document.lineAt(position.line).text.slice(wordRange.start.character, wordRange.end.character);
const currentWord: string = document.lineAt(position.line).text.slice(wordRange.start.character, wordRange.end.character); const ns = cljParser.getNamespace(document.getText());
const ns = cljParser.getNamespace(document.getText());

return nreplClient.info(currentWord, ns).then(info => {
nreplClient.info(currentWord, ns, (info) => { if (!info.file)
if (!info.file) return Promise.reject('No word definition found.');
return reject('No word definition found.');

let uri = vscode.Uri.parse(info.file);
let uri = vscode.Uri.parse(info.file); let pos = new vscode.Position(info.line - 1, info.column)
let pos = new vscode.Position(info.line - 1, info.column) let definition = new vscode.Location(uri, pos);
let definition = new vscode.Location(uri, pos); return Promise.resolve(definition);
resolve(definition); });
});
})
} }


} }
25 changes: 11 additions & 14 deletions src/clojureHover.ts
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -10,22 +10,19 @@ export class ClojureHoverProvider implements vscode.HoverProvider {
if (!cljConnection.isConnected()) if (!cljConnection.isConnected())
return Promise.reject('No nREPL connected.'); return Promise.reject('No nREPL connected.');


return new Promise<vscode.Hover>((resolve, reject) => { let wordRange = document.getWordRangeAtPosition(position);
let wordRange = document.getWordRangeAtPosition(position); if (wordRange === undefined)
if (wordRange === undefined) { return Promise.resolve(new vscode.Hover('Docstring not found'));
resolve(new vscode.Hover('Docstring not found'));
} else {
let currentWord: string;
currentWord = document.lineAt(position.line).text.slice(wordRange.start.character, wordRange.end.character);
const ns = cljParser.getNamespace(document.getText());


nreplClient.info(currentWord, ns, (info) => { let currentWord: string;
if (info.doc) { currentWord = document.lineAt(position.line).text.slice(wordRange.start.character, wordRange.end.character);
resolve(new vscode.Hover(info.doc)); const ns = cljParser.getNamespace(document.getText());
}
reject(); return nreplClient.info(currentWord, ns).then(info => {
}); if (info.doc) {
return Promise.resolve(new vscode.Hover(info.doc));
} }
return Promise.reject(undefined);
}); });
} }


Expand Down
14 changes: 6 additions & 8 deletions src/clojureSignature.ts
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -28,16 +28,14 @@ export class ClojureSignatureProvider implements vscode.SignatureHelpProvider {
return Promise.reject('No expression found.'); return Promise.reject('No expression found.');


const ns = cljParser.getNamespace(document.getText()); const ns = cljParser.getNamespace(document.getText());
return new Promise<vscode.SignatureHelp>((resolve, reject) => { return nreplClient.info(exprInfo.functionName, ns).then(info => {
nreplClient.info(exprInfo.functionName, ns, info => { if (!info.name) // sometimes info brings just a list of suggestions (example: .MAX_VALUE)
if (!info.name) // sometimes info brings just a list of suggestions (example: .MAX_VALUE) return Promise.reject('No signature info found.');
return reject('No signature info found.');


if (!!info['special-form']) if (!!info['special-form'])
return resolve(getSpecialFormSignatureHelp(info, exprInfo.parameterPosition)); return Promise.resolve(getSpecialFormSignatureHelp(info, exprInfo.parameterPosition));


return resolve(getFunctionSignatureHelp(info, exprInfo.parameterPosition)); return Promise.resolve(getFunctionSignatureHelp(info, exprInfo.parameterPosition));
});
}); });
} }


Expand Down
72 changes: 31 additions & 41 deletions src/clojureSuggest.ts
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -21,50 +21,40 @@ export class ClojureCompletionItemProvider implements vscode.CompletionItemProvi
if (!cljConnection.isConnected()) if (!cljConnection.isConnected())
return Promise.reject('No nREPL connected.'); return Promise.reject('No nREPL connected.');


return new Promise<vscode.CompletionList>((resolve, reject) => { // TODO: Use VSCode means for getting a current word
let document = vscode.window.activeTextEditor.document; let lineText = document.lineAt(position.line).text;

let words: string[] = lineText.split(' ');
// TODO: Use VSCode means for getting a current word let currentWord = words[words.length - 1].replace(/^[\('\[\{]+|[\)\]\}]+$/g, '');
let lineText = document.lineAt(position.line).text; let text = document.getText()
let words: string[] = lineText.split(' '); let ns = cljParser.getNamespace(text);
let currentWord = words[words.length - 1].replace(/^[\('\[\{]+|[\)\]\}]+$/g, '');
let text = document.getText() let currentWordLength: number = currentWord.length;
let ns = cljParser.getNamespace(text);

let buildInsertText = (suggestion: string) => {
let currentWordLength: number = currentWord.length; return suggestion[0] === '.' ? suggestion.slice(1) : suggestion;

}
let buildInsertText = (suggestion: string) => {
return suggestion[0] === '.' ? suggestion.slice(1) : suggestion; return nreplClient.complete(currentWord, ns).then(completions => {
} if (!('completions' in completions))

return Promise.reject(undefined);
nreplClient.complete(currentWord, ns, (completions) => {
let suggestions = []; let suggestions = completions.completions.map(element => ({
if ('completions' in completions) { label: element.candidate,
completions.completions.forEach(element => { kind: mappings[element.type] || vscode.CompletionItemKind.Text,
suggestions.push({ insertText: buildInsertText(element.candidate)
label: element.candidate, }));
kind: mappings[element.type] || vscode.CompletionItemKind.Text, let completionList: vscode.CompletionList = new vscode.CompletionList(suggestions, false);
insertText: buildInsertText(element.candidate) return Promise.resolve(completionList);
}) });
})
} else {
return reject();
}
let completionList: vscode.CompletionList = new vscode.CompletionList(suggestions, false);
resolve(completionList);
});
})
} }


public resolveCompletionItem(item: vscode.CompletionItem, token: vscode.CancellationToken): Thenable<vscode.CompletionItem> { public resolveCompletionItem(item: vscode.CompletionItem, token: vscode.CancellationToken): Thenable<vscode.CompletionItem> {
return new Promise<vscode.CompletionItem>((resolve, reject) => { let document = vscode.window.activeTextEditor.document;
let document = vscode.window.activeTextEditor.document; let ns = cljParser.getNamespace(document.getText());
let ns = cljParser.getNamespace(document.getText()); return nreplClient.info(item.label, ns).then(info => {
nreplClient.info(item.label, ns, (info) => { item.documentation = info.doc;
item.documentation = info.doc; return Promise.resolve(item);
resolve(item); });
});
})
} }


} }
8 changes: 4 additions & 4 deletions src/nreplClient.ts
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -42,14 +42,14 @@ interface nREPLCloseMessage {
op: string; op: string;
} }


const complete = (symbol: string, ns: string, callback): void => { const complete = (symbol: string, ns: string): Promise<any> => {
const msg: nREPLCompleteMessage = { op: 'complete', symbol, ns }; const msg: nREPLCompleteMessage = { op: 'complete', symbol, ns };
send(msg).then(respObjs => callback(respObjs[0])); return send(msg).then(respObjs => respObjs[0]);
}; };


const info = (symbol: string, ns: string, callback) => { const info = (symbol: string, ns: string): Promise<any> => {
const msg: nREPLInfoMessage = { op: 'info', symbol, ns }; const msg: nREPLInfoMessage = { op: 'info', symbol, ns };
send(msg).then(respObjs => callback(respObjs[0])); return send(msg).then(respObjs => respObjs[0]);
}; };


const evaluate = (code: string): Promise<any[]> => clone().then((new_session) => { const evaluate = (code: string): Promise<any[]> => clone().then((new_session) => {
Expand Down