Possible bug in clojureDefinition.ts

[simonvizzini]

Hey, I totally randomly stumbled upon your extension. I was just looking for some example VS Code language support extensions :)

While reading clojureDefinition.ts I noticed there is probably a return statement missing at line 31, or maybe I'm missing something. I think the code that follows should throw if info.file is null/undefined/empty? But apparently that never happened yet?

[avli]

Hi, @simonvizzini. We use JavaScript promise here, so it's totally fine to just call the reject() function which tells Visual Studio Code that attempt to find the definition was unsuccessful. Please see this page.

[simonvizzini]

I totally understand Promises, but you are calling reject without a return, which means code execution will continue after the reject. In other places you explicitly call return reject(..)

[avli]

Very good point. It's actually me who doesn't understand Promises :-) I fixed the bug.

Thanks again!

[simonvizzini]

You're welcome! I use the same return reject/resolve pattern myself in my own code and it happened to me so many times that I forgot the return statement, so that's why this immediately caught my eye while reading your code ;)