GORM adapter #26
Merged
GORM adapter #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maranqz
force-pushed
the
gorm-adapter
branch
from
31e70a6 to
388b00d
Compare
|
Coverage after merging gorm-adapter into main
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Coverage after merging gorm-adapter into main
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
maranqz
force-pushed
the
gorm-adapter
branch
from
084c1c4 to
09f4b4f
Compare
|
Coverage after merging gorm-adapter into main
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
@Flaiers if you have time, you can check PR. |
Flaiers
suggested changes
Nov 14, 2022
maranqz
commented
Nov 18, 2022
| @@ -195,12 +195,12 @@ func TestTransaction(t *testing.T) { | |||
| }) | |||
|
|
|||
| if trNested != nil { | |||
| require.Equal(t, true, trNested.IsActive()) | |||
| require.True(t, trNested.IsActive()) | |||
There was a problem hiding this comment.
I simplified the code. I didn't moved it to another PR because it is small changes.
@Flaiers
#26 (review)
Flaiers
approved these changes
Nov 21, 2022
maranqz
force-pushed
the
gorm-adapter
branch
from
09f4b4f to
057613f
Compare
maranqz
added a commit
that referenced
this pull request
Nov 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.