-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V1 #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. moving context in transaction pkg 2. moving manager in transaction pkg 3. added sql integration
1. moving setting, manager in package 2. fix linter
1. add settings in manager 2. update Tr interfaces 3. add timeout in settings
1. Create Settings interface 2. Create Transaction interface 3. Move manager to common part
1. add errors 2. implement PropagationNever, PropagationsMandatory, PropagationRequired
1. implement PropagationNested, PropagationNotSupported, PropagationRequiresNew 2. settings can be updated 3. Run transaction with settings
1. add simple unit test on manager
1. add tests on panic, commit, rollback and all propogation 2. fix error returning 3. fix rollback without error
1. add tests on panic, commit, rollback and all propogation 2. fix error returning 3. fix rollback without error
1. decrease go version 2. fix sqlx contract
Propagation
1. add ChainedMW, tests, example 2. add test for sql, sqlx Transaction
V1 chained transaction
1. fix settings 2. add propagation of context err 3. fix deactivating commit, rollback after cancel 4. add settings for cancel and timeout transaction 5. rename NewFactory to NewDefaultFactory 6. fix isActive for goroutines 7. use isActive to check before close transaction, add ErrAlreadyClosed
V1 transaction control
1. move save point only in sql 2. add settings in mongo, sql
V1 transaction options
1. add example 2. add error for Options 3. add Must function 4. add badges 5. rename transaction package to trm 6. add codecoverage in pull request 7. add mongo test with real database
Prepare for publication
# Conflicts: # go.mod # go.sum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.