Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mlops-131 user managed notebooks sync and push for all notebooks #36

Merged
merged 5 commits into from
Sep 6, 2022

Conversation

michalmrazek
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2022

Codecov Report

Merging #36 (d8ad1ab) into master (7dd4df3) will decrease coverage by 0.62%.
The diff coverage is 55.10%.

@@            Coverage Diff             @@
##           master      #36      +/-   ##
==========================================
- Coverage   72.80%   72.18%   -0.63%     
==========================================
  Files          55       55              
  Lines        2434     2545     +111     
==========================================
+ Hits         1772     1837      +65     
- Misses        662      708      +46     
Impacted Files Coverage Δ
src/wanna/cli/plugins/common_options.py 100.00% <ø> (ø)
src/wanna/core/services/notebook.py 59.77% <33.33%> (-9.41%) ⬇️
src/wanna/core/services/base.py 55.91% <38.09%> (-5.73%) ⬇️
src/wanna/core/services/managed_notebook.py 64.53% <45.45%> (-0.65%) ⬇️
src/wanna/core/services/docker.py 68.85% <76.92%> (+0.46%) ⬆️
src/wanna/cli/plugins/managed_notebook_plugin.py 96.22% <86.66%> (+5.98%) ⬆️
src/wanna/cli/plugins/notebook_plugin.py 96.66% <90.00%> (-3.34%) ⬇️
src/wanna/core/models/base_instance.py 100.00% <100.00%> (ø)
src/wanna/core/models/notebook.py 100.00% <100.00%> (ø)
src/wanna/core/services/jobs.py 77.24% <0.00%> (-0.39%) ⬇️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@JacekHebda JacekHebda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, big props for the metadata addition ;)

src/wanna/cli/plugins/common_options.py Outdated Show resolved Hide resolved
src/wanna/cli/plugins/managed_notebook_plugin.py Outdated Show resolved Hide resolved
src/wanna/core/services/docker.py Outdated Show resolved Hide resolved
src/wanna/core/services/notebook.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@jsilva jsilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@michalmrazek michalmrazek merged commit 6dfb162 into master Sep 6, 2022
@michalmrazek michalmrazek deleted the michal/notebook_sync branch September 6, 2022 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants