Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure call to GCP only happens when cloud build is enabled #125

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

jsilva
Copy link
Collaborator

@jsilva jsilva commented Mar 16, 2024

Describe your changes

As we need to be able to build and push containers in an environment without access to GCP Artifact Registry/Cloud Build, the call to get project_number in docker service can only happen when we already know cloud build and GCP access env is allowed.

This PR moves the call to the single function that uses it, instead of the init

@jsilva jsilva requested a review from racinmat March 16, 2024 08:08
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 74.46%. Comparing base (2dc036b) to head (2244019).

Files Patch % Lines
src/wanna/core/services/docker.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #125      +/-   ##
==========================================
- Coverage   74.50%   74.46%   -0.04%     
==========================================
  Files          58       58              
  Lines        2867     2867              
==========================================
- Hits         2136     2135       -1     
- Misses        731      732       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@racinmat racinmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
00235-2154305477

@jsilva jsilva merged commit 111ded4 into master Mar 18, 2024
3 checks passed
@jsilva jsilva deleted the joao/fix-cloud-build-project-number branch March 18, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants