Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logging.basicConfig() conflicts with use as a library #27

Closed
benthorner opened this issue Nov 15, 2021 · 1 comment · Fixed by #28
Closed

logging.basicConfig() conflicts with use as a library #27

benthorner opened this issue Nov 15, 2021 · 1 comment · Fixed by #28
Labels
enhancement New feature or request

Comments

@benthorner
Copy link
Contributor

Great codebase - really helpful to have all this knowledge in one place!

I've started using pms as a library in my own project. A small problem I encountered is this line, which means I have to use force=True when I call logging.basicConfig in order for it to pick up my preferred settings.

Would it be possible to move that line to the pms.cli module? I reckon that should preserve the existing behaviour for CLI users. Happy to make a PR for it but thought it would be best to ask first.
@avaldebe avaldebe added the enhancement New feature or request label Nov 16, 2021
@avaldebe
Copy link
Owner

Would it be possible to move that line to the pms.cli module? I reckon that should preserve the existing behaviour for CLI users.
Happy to make a PR for it but thought it would be best to ask first.

Sure, PRs are most welcomed

@benthorner benthorner mentioned this issue Nov 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move root logger config to CLI module benthorner/PyPMS
2 participants
@avaldebe @benthorner