Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Node 22 #3327

Closed
ehmicky opened this issue Apr 28, 2024 · 6 comments · Fixed by #3328
Closed

Add support for Node 22 #3327

ehmicky opened this issue Apr 28, 2024 · 6 comments · Fixed by #3328
Labels

Comments

@ehmicky
Copy link

ehmicky commented Apr 28, 2024

  • What you're trying to do

Use Ava with Node 22.

  • Why you can't use AVA for this

If --engine-strict is used, npm install fails with:

npm error code EBADENGINE
npm error engine Unsupported engine
npm error engine Not compatible with your version of node/npm: ava@6.1.2
npm error notsup Not compatible with your version of node/npm: ava@6.1.2
npm error notsup Required: {"node":"^18.18 || ^20.8 || ^21"}
npm error notsup Actual:   {"npm":"10.6.0","node":"v22.0.0"}

If --engine-strict is not used, the following warning is printed, but npm install does not fail:

npm warn EBADENGINE Unsupported engine {
npm warn EBADENGINE   package: 'ava@6.1.2',
npm warn EBADENGINE   required: { node: '^18.18 || ^20.8 || ^21' },
npm warn EBADENGINE   current: { node: 'v22.0.0', npm: '10.6.0' }
npm warn EBADENGINE }
  • And maybe how you think AVA could handle this

Upgrade the following:

"node": "^18.18 || ^20.8 || ^21"

However, there might be more work required due to the breaking changes that come with Node 22.

@arlac77
Copy link
Contributor

arlac77 commented Apr 30, 2024

Beside the warning I have no issues running ava on node 22.0.0 (OSX)

@lenovouser
Copy link
Contributor

I just tested on a few repositories of ours and ava v6.1.2 does work flawlessly with node v22.0.0

@lenovouser
Copy link
Contributor

#3328

@ehmicky
Copy link
Author

ehmicky commented May 5, 2024

Thanks @lenovouser and @novemberborn!

@ehmicky
Copy link
Author

ehmicky commented Oct 26, 2024

The same problem is now happening for Node 23.

npm error code EBADENGINE
npm error engine Unsupported engine
npm error engine Not compatible with your version of node/npm: ava@6.1.3
npm error notsup Not compatible with your version of node/npm: ava@6.1.3
npm error notsup Required: {"node":"^18.18 || ^20.8 || ^21 || ^22"}
npm error notsup Actual:   {"npm":"10.9.0","node":"v23.0.0"}

@novemberborn
Copy link
Member

@ehmicky sorted.

@avajs avajs locked as resolved and limited conversation to collaborators Oct 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants