Skip to content

Support Generic Records #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 2, 2023
Merged

Support Generic Records #47

merged 7 commits into from
Jan 2, 2023

Conversation

SentryMan
Copy link
Collaborator

@SentryMan SentryMan commented Dec 27, 2022 •
edited
Loading

Now generics work with nested classes and records

  • Uses the TypeElement getRecordComponents to determine if a class is a record
  • Now always generates record fields in fromJson (as a result, @ignore now works on records)
  • Factory Names on the GeneratedJsonComponent now generate properly for nested classes
  • now GenericAdapters have the name of the Generic Type (before was having issues with classes with the <T, T2, T3...> naming convention)

Part of #39

@SentryMan SentryMan mentioned this pull request Dec 28, 2022
Merged
@rbygrave rbygrave merged commit a4c9d89 into avaje:main Jan 2, 2023
@rbygrave rbygrave added this to the 1.1 milestone Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbygrave rbygrave rbygrave approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@SentryMan @rbygrave