Skip to content

Fix external dependency error messages #843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SentryMan
Copy link
Collaborator

@SentryMan SentryMan commented Jun 26, 2025

Now will pinpoint the exact missing dependency in the error message when external beans are involved.

before given class

@Singleton
public class ExternalDeps {
  @Inject @Nullable AtomicLong longy;

  public ExternalDeps(AtomicBoolean bool, @External AtomicInteger inty) {}
}

it would error with

Dependencies [java.util.concurrent.atomic.AtomicBoolean, java.util.concurrent.atomic.AtomicInteger] are not provided

Now it will correctly error with

Dependencies [java.util.concurrent.atomic.AtomicBoolean] are not provided

now will pinpoint the exact missing dependency in the error message when external beans are involved
@SentryMan SentryMan added this to the 11.6 milestone Jun 26, 2025
@SentryMan SentryMan requested a review from rbygrave June 26, 2025 22:58
@SentryMan SentryMan self-assigned this Jun 26, 2025
@SentryMan SentryMan added the bug Something isn't working label Jun 26, 2025
@SentryMan SentryMan enabled auto-merge (squash) June 26, 2025 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant