Skip to content

Validate only a single @InjectModule annotation #776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 12, 2025

Conversation

SentryMan
Copy link
Collaborator

@SentryMan SentryMan commented Mar 12, 2025

Saw some cases where users had multiple for whatever reason and it wasn't working right. (strict wiring was being overridden)

  • validates that no extra @InjectModules are lying around
  • filter out generated classes from validation (we expect to read them)
  • filter out custom scope annotations as well

Saw some cases where users had multiple for whatever reason and it wasn't working right. (strict wiring was being overridden)
@SentryMan SentryMan requested a review from rbygrave March 12, 2025 03:26
@SentryMan SentryMan self-assigned this Mar 12, 2025
@SentryMan SentryMan added this to the 11.3 milestone Mar 12, 2025
@SentryMan SentryMan enabled auto-merge (squash) March 12, 2025 03:27
@SentryMan SentryMan merged commit 22134d8 into avaje:master Mar 12, 2025
7 checks passed
@SentryMan SentryMan deleted the duplicate-inject-module branch March 12, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants