Skip to content

Javadoc for AvajeJavalinPlugin and tidy javalin ControllerWriter only #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 1, 2023
Merged

Javadoc for AvajeJavalinPlugin and tidy javalin ControllerWriter only #342

merged 1 commit into from
Nov 1, 2023

Conversation

rob-bygrave
Copy link
Contributor

@rob-bygrave rob-bygrave commented Nov 1, 2023 •
edited
Loading

Notes / thoughts:

  • AvajeJavalinPlugin could almost be called AvajeJavalinRoute
  • Oh, I don't like that the Javalin Plugin is an abstract type - yuk !!!

@SentryMan SentryMan enabled auto-merge November 1, 2023 22:48
@SentryMan SentryMan merged commit cc2c233 into master Nov 1, 2023
@SentryMan SentryMan deleted the feature/tidy-n-javadoc branch November 1, 2023 22:48
@rob-bygrave
Copy link
Contributor Author

FYI: I've added a comment to the Javalin PR that changed Plugin into an abstract type, will see what the reply there is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SentryMan SentryMan SentryMan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rob-bygrave @SentryMan