[http client] Generation for @Client.Import when argument names lost #293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the interface has been previously compiled then the method arg names are effectively lost - become arg0, arg1, arg2 etc. In this case the generation can get the implied arg names for path parameters from the segments but for @QueryParam and @Header parameters we now need explicitly named arguments. This change handles the path segments and gives a reasonable error for QueryParams and Headers etc that are not explicitly named.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the interface has been previously compiled then the method arg names are effectively lost - become arg0, arg1, arg2 etc. In this case the generation can get the implied arg names for path parameters from the segments but for @QueryParam and @Header parameters we now need explicitly named arguments.
This change handles the path segments and gives a reasonable error for QueryParams and Headers etc that are not explicitly named.