Skip to content

[Http Api] Remove deprecated instrumentRequestContext() #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jul 21, 2023
Merged

[Http Api] Remove deprecated instrumentRequestContext() #228

merged 11 commits into from
Jul 21, 2023

Conversation

SentryMan
Copy link
Collaborator

@SentryMan SentryMan commented Jun 16, 2023 •
edited
Loading

  • We have a dedicated annotation for server context
  • HTTP provider's type method is not being used anywhere (client impls are meant to be registered via the GeneratedComponent rather than directly service-loaded)

@rob-bygrave rob-bygrave changed the title Remove all Deprecated stuff [Http Api] Remove deprecated instrumentRequestContext() Jun 19, 2023
@rob-bygrave rob-bygrave added this to the 2.0 milestone Jun 19, 2023
@rbygrave rbygrave merged commit 9b61ba0 into avaje:master Jul 21, 2023
@SentryMan SentryMan deleted the deprecated branch July 21, 2023 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@SentryMan SentryMan

Labels

None yet

Projects

None yet

Milestone

2.0

Development

Successfully merging this pull request may close these issues.

3 participants

@SentryMan @rbygrave @rob-bygrave