Skip to content

Create @MatrixParam Annotation #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 8, 2023
Merged

Create @MatrixParam Annotation #119

merged 3 commits into from
Jan 8, 2023

Conversation

SentryMan
Copy link
Collaborator

@SentryMan SentryMan commented Jan 6, 2023 •
edited
Loading

Now I've never used matrix params in my life. But if I did, I'd celebrate having goofy characters like hyphens.

  • Creates new annotation
  • Element reader detects this annotation and uses the value if available
  • sanitizes generated path segment names

Solves #43

@rbygrave rbygrave added this to the 1.21 milestone Jan 8, 2023
@rbygrave rbygrave merged commit 664e93b into avaje:master Jan 8, 2023
@rbygrave rbygrave added the enhancement New feature or request label Jan 8, 2023
@SentryMan SentryMan deleted the matrix-dodge branch January 8, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SentryMan SentryMan

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.21
Development

Successfully merging this pull request may close these issues.
2 participants
@SentryMan @rbygrave