Skip to content

Commit ea5831d

Browse files
authored
Merge pull request #227 from avaje/feature/delete-httpclientcontext
[HttpClient] Remove deprecated HttpClientContext, migrate to HttpClient
2 parents 20db385 + f75b45a commit ea5831d

File tree

4 files changed

+27
-351
lines changed

4 files changed

+27
-351
lines changed

http-client/src/main/java/io/avaje/http/client/DHttpClientContext.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
import java.util.concurrent.atomic.LongAccumulator;
1616
import java.util.concurrent.atomic.LongAdder;
1717

18-
final class DHttpClientContext implements HttpClientContext, SpiHttpClient {
18+
final class DHttpClientContext implements HttpClient, SpiHttpClient {
1919

2020
/**
2121
* HTTP Authorization header.
@@ -75,7 +75,7 @@ public <T> T create(Class<T> clientInterface) {
7575
private <T> T constructReflectively(Class<T> clientInterface) {
7676
try {
7777
final Class<?> implementationClass = implementationClass(clientInterface);
78-
final Constructor<?> constructor = implementationClass.getConstructor(HttpClientContext.class);
78+
final Constructor<?> constructor = implementationClass.getConstructor(HttpClient.class);
7979
return (T) constructor.newInstance(this);
8080
} catch (final Exception e) {
8181
final String cn = implementationClassName(clientInterface, "HttpClient");

http-client/src/main/java/io/avaje/http/client/DHttpClientContextBuilder.java

Lines changed: 23 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
import java.net.Authenticator;
44
import java.net.CookieHandler;
55
import java.net.ProxySelector;
6-
import java.net.http.HttpClient;
76
import java.time.Duration;
87
import java.util.Collections;
98
import java.util.concurrent.Executor;
@@ -13,121 +12,121 @@
1312

1413
import io.avaje.inject.BeanScope;
1514

16-
final class DHttpClientContextBuilder extends DBaseBuilder implements HttpClientContext.Builder, HttpClientContext.Builder.State {
15+
final class DHttpClientContextBuilder extends DBaseBuilder implements HttpClient.Builder, HttpClient.Builder.State {
1716

1817
DHttpClientContextBuilder() {
1918
}
2019

2120
@Override
22-
public HttpClientContext.Builder client(HttpClient client) {
21+
public HttpClient.Builder client(java.net.http.HttpClient client) {
2322
this.client = client;
2423
return this;
2524
}
2625

2726
@Override
28-
public HttpClientContext.Builder baseUrl(String baseUrl) {
27+
public HttpClient.Builder baseUrl(String baseUrl) {
2928
this.baseUrl = baseUrl;
3029
return this;
3130
}
3231

3332
@Override
34-
public HttpClientContext.Builder connectionTimeout(Duration connectionTimeout) {
33+
public HttpClient.Builder connectionTimeout(Duration connectionTimeout) {
3534
this.connectionTimeout = connectionTimeout;
3635
return this;
3736
}
3837

3938
@Override
40-
public HttpClientContext.Builder requestTimeout(Duration requestTimeout) {
39+
public HttpClient.Builder requestTimeout(Duration requestTimeout) {
4140
this.requestTimeout = requestTimeout;
4241
return this;
4342
}
4443

4544
@Override
46-
public HttpClientContext.Builder bodyAdapter(BodyAdapter adapter) {
45+
public HttpClient.Builder bodyAdapter(BodyAdapter adapter) {
4746
this.bodyAdapter = adapter;
4847
return this;
4948
}
5049

5150
@Override
52-
public HttpClientContext.Builder retryHandler(RetryHandler retryHandler) {
51+
public HttpClient.Builder retryHandler(RetryHandler retryHandler) {
5352
this.retryHandler = retryHandler;
5453
return this;
5554
}
5655

5756
@Override
58-
public HttpClientContext.Builder requestLogging(boolean requestLogging) {
57+
public HttpClient.Builder requestLogging(boolean requestLogging) {
5958
this.requestLogging = requestLogging;
6059
return this;
6160
}
6261

6362
@Override
64-
public HttpClientContext.Builder requestListener(RequestListener... requestListener) {
63+
public HttpClient.Builder requestListener(RequestListener... requestListener) {
6564
Collections.addAll(listeners, requestListener);
6665
return this;
6766
}
6867

6968
@Override
70-
public HttpClientContext.Builder requestIntercept(RequestIntercept... requestIntercept) {
69+
public HttpClient.Builder requestIntercept(RequestIntercept... requestIntercept) {
7170
Collections.addAll(interceptors, requestIntercept);
7271
return this;
7372
}
7473

7574
@Override
76-
public HttpClientContext.Builder authTokenProvider(AuthTokenProvider authTokenProvider) {
75+
public HttpClient.Builder authTokenProvider(AuthTokenProvider authTokenProvider) {
7776
this.authTokenProvider = authTokenProvider;
7877
return this;
7978
}
8079

8180
@Override
82-
public HttpClientContext.Builder cookieHandler(CookieHandler cookieHandler) {
81+
public HttpClient.Builder cookieHandler(CookieHandler cookieHandler) {
8382
this.cookieHandler = cookieHandler;
8483
return this;
8584
}
8685

8786
@Override
88-
public HttpClientContext.Builder redirect(HttpClient.Redirect redirect) {
87+
public HttpClient.Builder redirect(java.net.http.HttpClient.Redirect redirect) {
8988
this.redirect = redirect;
9089
return this;
9190
}
9291

9392
@Override
94-
public HttpClientContext.Builder version(HttpClient.Version version) {
93+
public HttpClient.Builder version(java.net.http.HttpClient.Version version) {
9594
this.version = version;
9695
return this;
9796
}
9897

9998
@Override
100-
public HttpClientContext.Builder executor(Executor executor) {
99+
public HttpClient.Builder executor(Executor executor) {
101100
this.executor = executor;
102101
return this;
103102
}
104103

105104
@Override
106-
public HttpClientContext.Builder proxy(ProxySelector proxySelector) {
105+
public HttpClient.Builder proxy(ProxySelector proxySelector) {
107106
this.proxy = proxySelector;
108107
return this;
109108
}
110109

111110
@Override
112-
public HttpClientContext.Builder sslContext(SSLContext sslContext) {
111+
public HttpClient.Builder sslContext(SSLContext sslContext) {
113112
this.sslContext = sslContext;
114113
return this;
115114
}
116115

117116
@Override
118-
public HttpClientContext.Builder sslParameters(SSLParameters sslParameters) {
117+
public HttpClient.Builder sslParameters(SSLParameters sslParameters) {
119118
this.sslParameters = sslParameters;
120119
return this;
121120
}
122121

123122
@Override
124-
public HttpClientContext.Builder authenticator(Authenticator authenticator) {
123+
public HttpClient.Builder authenticator(Authenticator authenticator) {
125124
this.authenticator = authenticator;
126125
return this;
127126
}
128127

129128
@Override
130-
public HttpClientContext.Builder priority(int priority) {
129+
public HttpClient.Builder priority(int priority) {
131130
this.priority = priority;
132131
return this;
133132
}
@@ -138,13 +137,13 @@ public State state() {
138137
}
139138

140139
@Override
141-
public HttpClientContext.Builder configureWith(BeanScope beanScope) {
140+
public HttpClient.Builder configureWith(BeanScope beanScope) {
142141
super.configureFromScope(beanScope);
143142
return this;
144143
}
145144

146145
@Override
147-
public HttpClientContext build() {
146+
public HttpClient build() {
148147
return super.buildClient();
149148
}
150149

@@ -159,7 +158,7 @@ public BodyAdapter bodyAdapter() {
159158
}
160159

161160
@Override
162-
public HttpClient client() {
161+
public java.net.http.HttpClient client() {
163162
return client;
164163
}
165164

0 commit comments

Comments
 (0)