Skip to content

Commit 6b851ac

Browse files
authored
[client] Generate classes as final (#547)
1 parent ee2abcf commit 6b851ac

File tree

3 files changed

+4
-2
lines changed

3 files changed

+4
-2
lines changed

http-client/src/test/java/io/avaje/http/client/DHttpClientRequestTest.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
import java.time.Duration;
66
import java.util.List;
77

8+
import org.junit.jupiter.api.Disabled;
89
import org.junit.jupiter.api.Test;
910

1011
class DHttpClientRequestTest {
@@ -34,6 +35,7 @@ void assertHeader() {
3435
assertThat(headers).asList().contains("application/json", "application/json2");
3536
}
3637

38+
@Disabled
3739
@Test
3840
void assertQuery() {
3941
final var client = HttpClient.builder().baseUrl("https://ap7i.github.com").build();

http-generator-client/src/main/java/io/avaje/http/generator/client/ClientWriter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ private void writeClassStart() {
7373
writer.append(AT_GENERATED).eol();
7474
AnnotationUtil.writeAnnotations(writer, reader.beanType());
7575

76-
writer.append("public class %s%s implements %s, AutoCloseable {", shortName, suffix, shortName).eol().eol();
76+
writer.append("public final class %s%s implements %s, AutoCloseable {", shortName, suffix, shortName).eol().eol();
7777

7878
writer.append(" private final HttpClient client;").eol().eol();
7979

http-generator-client/src/main/java/io/avaje/http/generator/client/SimpleComponentWriter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ private void writeClassStart() {
8181
final List<String> all = metaData.all();
8282
writeMetaDataEntry(all);
8383
writer.append("})").eol();
84-
writer.append("public class %s implements HttpClient.GeneratedComponent {", shortName).eol().eol();
84+
writer.append("public final class %s implements HttpClient.GeneratedComponent {", shortName).eol().eol();
8585
}
8686

8787
private void writeMetaDataEntry(List<String> entries) {

0 commit comments

Comments
 (0)