Skip to content

Commit 2f5cf18

Browse files
committed
fix
1 parent 67eb2a1 commit 2f5cf18

File tree

2 files changed

+25
-25
lines changed

2 files changed

+25
-25
lines changed

http-generator-client/src/main/java/io/avaje/http/generator/client/ClientMethodWriter.java

Lines changed: 24 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -107,14 +107,12 @@ private void writeEnd() {
107107
String known = KNOWN_RESPONSE.get(returnType.full());
108108
if (known != null) {
109109
writer.append(" %s", known).eol();
110+
} else if (COMPLETABLE_FUTURE.equals(returnType.mainType())) {
111+
writeAsyncResponse();
112+
} else if (HTTP_CALL.equals(returnType.mainType())) {
113+
writeCallResponse();
110114
} else {
111-
if (COMPLETABLE_FUTURE.equals(returnType.mainType())) {
112-
writeAsyncResponse();
113-
} else if (HTTP_CALL.equals(returnType.mainType())) {
114-
writeCallResponse();
115-
} else {
116-
writeSyncResponse();
117-
}
115+
writeSyncResponse();
118116
}
119117
}
120118
writer.append(" }").eol().eol();
@@ -145,24 +143,28 @@ private void writeResponse(UType type) {
145143
} else if (isStream(mainType)) {
146144
writer.append(".stream(");
147145
writeGeneric(param1);
146+
writer.append(");").eol();
148147
} else if (isHttpResponse(mainType)) {
149148
if (bodyHandlerParam == null) {
150-
UType paramType = type.paramRaw();
151-
if (paramType.mainType().equals("java.util.List")) {
149+
final UType paramType = type.paramRaw();
150+
if ("java.util.List".equals(paramType.mainType())) {
152151
writer.append(".asList(");
153152
writeGeneric(paramType.paramRaw());
154-
} else if (paramType.mainType().equals("java.util.stream.Stream")) {
153+
} else if ("java.util.stream.Stream".equals(paramType.mainType())) {
155154
writer.append(".asStream(");
156155
writeGeneric(paramType.paramRaw());
157156
} else {
158157
writer.append(".as(");
159158
writeGeneric(paramType);
160159
}
160+
writer.append(");").eol();
161161
} else {
162-
writer.append(".handler(%s);", bodyHandlerParam.name()).eol(); }
162+
writer.append(".handler(%s);", bodyHandlerParam.name()).eol();
163+
}
163164
} else {
164165
writer.append(".bean(");
165166
writeGeneric(type);
167+
writer.append(");").eol();
166168
}
167169
}
168170

@@ -181,15 +183,13 @@ void writeGeneric(UType type) {
181183
}
182184

183185
private void writeQueryParams(PathSegments pathSegments) {
184-
for (MethodParam param : method.params()) {
185-
ParamType paramType = param.paramType();
186-
if (paramType == ParamType.QUERYPARAM) {
187-
if (pathSegments.segment(param.paramName()) == null) {
188-
if (isMap(param)) {
189-
writer.append(" .queryParam(%s)", param.name()).eol();
190-
} else {
191-
writer.append(" .queryParam(\"%s\", %s)", param.paramName(), param.name()).eol();
192-
}
186+
for (final MethodParam param : method.params()) {
187+
final ParamType paramType = param.paramType();
188+
if (paramType == ParamType.QUERYPARAM && pathSegments.segment(param.paramName()) == null) {
189+
if (isMap(param)) {
190+
writer.append(" .queryParam(%s)", param.name()).eol();
191+
} else {
192+
writer.append(" .queryParam(\"%s\", %s)", param.paramName(), param.name()).eol();
193193
}
194194
}
195195
}
@@ -280,19 +280,19 @@ private boolean isMap(MethodParam param) {
280280
}
281281

282282
private boolean isMap(String type0) {
283-
return type0.equals("java.util.Map");
283+
return "java.util.Map".equals(type0);
284284
}
285285

286286
private boolean isList(String type0) {
287-
return type0.equals("java.util.List");
287+
return "java.util.List".equals(type0);
288288
}
289289

290290
private boolean isStream(String type0) {
291-
return type0.equals("java.util.stream.Stream");
291+
return "java.util.stream.Stream".equals(type0);
292292
}
293293

294294
private boolean isHttpResponse(String type0) {
295-
return type0.equals("java.net.http.HttpResponse");
295+
return "java.net.http.HttpResponse".equals(type0);
296296
}
297297

298298
}

tests/test-javalin-jsonb/src/main/java/org/example/myapp/web/test/ServerType.java renamed to tests/test-javalin-jsonb/src/main/java/org/example/myapp/web/ServerType.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package org.example.myapp.web.test;
1+
package org.example.myapp.web;
22

33
public enum ServerType {
44
PROXY,

0 commit comments

Comments
 (0)