You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After applying the patch, then iterate manually over rejected files. at this point I preferred iterating over coreth diffs in a separate window and checked differences manually. I.e open 2 windows one:
1- within coreth that shows diffs between v0.11.3 to v0.11.6
2- subnet-evm
and compare missing differences in folders with those rejected files.
After finishing with rejected differences do these (keeping this order could make it easier)
Replace coreth/ import paths with subnet-evm/ in .go files
Make sure you've updated the LATEST_CORETH_VERSION in scripts/version.sh to the synced coreth version (v0.11.6)
Change any Apricot/Banff/Cortina upgrades to SubnetEVM as SubnetEVM upgrade supposed to represent all of them combined.
Fix tests if broken
go mod tidy
Compare current workspace with coreth-v0.11.6.
You can take a look at changed files between coreth-v0.11.6 and coreth-v0.11.3, to see if something missing in sync.
Even after everything there could be additional required changes or some changes need to be reverted manually.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Assume we're syncing to coreth v0.11.6 and coreth v0.11.3 was the last synced tag to subnet-evm (prior to this PR)
After applying the patch, then iterate manually over rejected files. at this point I preferred iterating over coreth diffs in a separate window and checked differences manually. I.e open 2 windows one:
1- within coreth that shows diffs between v0.11.3 to v0.11.6
2- subnet-evm
and compare missing differences in folders with those rejected files.
After finishing with rejected differences do these (keeping this order could make it easier)
.go
filesLATEST_CORETH_VERSION
inscripts/version.sh
to the synced coreth version (v0.11.6)SubnetEVM
upgrade supposed to represent all of them combined.go mod tidy
Even after everything there could be additional required changes or some changes need to be reverted manually.
Beta Was this translation helpful? Give feedback.
All reactions