simplify test #1268
Merged
simplify test #1268
+9
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceyonur
commented
Sep 23, 2025
alarso16
approved these changes
Sep 23, 2025
Contributor
alarso16
left a comment
alarso16
left a comment
There was a problem hiding this comment.
This looks good to me. The GasFeeCap and GasTipCap do seem irrelevant to the test
JonathanOppenheimer
pushed a commit
that referenced
this pull request
Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
The test was trying to create a block from scratch which was expected pass all verification checks but
verifyIntrinsicGas. This makes it pretty much a very general test that needs to be modified once we add new checks. See: https://github.com/ava-labs/coreth/actions/runs/17954616010/job/51062564470?pr=1263#step:10:274How this works
Defers block building to vm, so that it will return a correct block. Then it modifies relevant parts
How this was tested
UT
Need to be documented?
no
Need to update RELEASES.md?
no