style: enable predeclared linter

.avalanche-golangci.yml

@@ -72,7 +72,7 @@ linters:
     - nolintlint
     - perfsprint
     - prealloc
-    # - predeclared
+    - predeclared
     - revive
     - spancheck
     - staticcheck

plugin/evm/atomic/tx.go

@@ -337,6 +337,6 @@ func CalculateDynamicFee(cost uint64, baseFee *big.Int) (uint64, error) {
 	return fee.Uint64(), nil
 }
 
-func calcBytesCost(len int) uint64 {
-	return uint64(len) * TxBytesGas
+func calcBytesCost(n int) uint64 {
+	return uint64(n) * TxBytesGas
 }

utils/bounded_workers.go

@@ -18,10 +18,10 @@ type BoundedWorkers struct {
 }
 
 // NewBoundedWorkers returns an instance of [BoundedWorkers] that
-// will spawn up to [max] goroutines.
-func NewBoundedWorkers(max int) *BoundedWorkers {
+// will spawn up to count goroutines.
+func NewBoundedWorkers(count int) *BoundedWorkers {
 	return &BoundedWorkers{
-		workerSpawner: make(chan struct{}, max),
+		workerSpawner: make(chan struct{}, count),
 		work:          make(chan func()),
 	}
 }