Register secp256r1 precompile #1044
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceyonur
reviewed
Aug 12, 2025
Signed-off-by: Jonathan Oppenheimer <jonathan.oppenheimer@avalabs.org>
ceyonur
previously requested changes
Aug 25, 2025
Signed-off-by: Jonathan Oppenheimer <jonathan.oppenheimer@avalabs.org>
ceyonur
reviewed
Aug 26, 2025
Co-authored-by: Ceyhun Onur <ceyhun.onur@avalabs.org> Signed-off-by: Jonathan Oppenheimer <147infiniti@gmail.com>
Signed-off-by: Jonathan Oppenheimer <jonathan.oppenheimer@avalabs.org>
ARR4N
reviewed
Sep 2, 2025
ARR4N
reviewed
Sep 3, 2025
ARR4N
previously requested changes
Sep 4, 2025
StephenButtolph
approved these changes
Sep 12, 2025
Contributor
StephenButtolph
left a comment
StephenButtolph
left a comment
There was a problem hiding this comment.
Can we add an E2E test for this precompile into the avalanchego test suite for Granite?
I suppose we could also add a unit test... but tbh I feel like this is a good candidate for an E2E test.
Co-authored-by: Stephen Buttolph <stephen@avalabs.org> Signed-off-by: Jonathan Oppenheimer <147infiniti@gmail.com>
ARR4N
approved these changes
Sep 12, 2025
Collaborator
ARR4N
left a comment
ARR4N
left a comment
There was a problem hiding this comment.
LGTM pending resolution of Stephen's suggestions.
Member
Author
That PR would be made in the AvalancheGo repository correct? Would you like me to attempt that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
ACP-204 implemented secp256r1 Curve Support as a precompile to allow cheaper verification of "modern device security systems" that use this curve. It was already added to libevm in ava-labs/libevm#184.
Close #1042
How this works
This PR registers the libevm p256verify precompiles as a stateless precompile gatekept by the Granite release
How this was tested
precompile/contracts/p256verify/contract_test.goand standard CI.Need to be documented?
I'm not sure...
Need to update RELEASES.md?
Probably? I'm also not sure... are users informed when a new precompile is provided?