style: enable staticcheck linter (#1197)

Signed-off-by: Jonathan Oppenheimer <147infiniti@gmail.com>
Signed-off-by: Jonathan Oppenheimer <jonathan.oppenheimer@avalabs.org>
Co-authored-by: Austin Larson <78000745+alarso16@users.noreply.github.com>
Co-authored-by: Stephen Buttolph <stephen@avalabs.org>

Author: 3 people

.avalanche-golangci.yml

@@ -75,7 +75,7 @@ linters:
     # - predeclared
     - revive
     - spancheck
-    # - staticcheck
+    - staticcheck
     - tagalign
     # - testifylint
     - unconvert

accounts/abi/abi_extra_test.go

@@ -15,10 +15,10 @@ import (
 
 // Note: This file contains tests in addition to those found in go-ethereum.
 
-const TEST_ABI = `[{"type":"function","name":"receive","inputs":[{"name":"sender","type":"address"},{"name":"amount","type":"uint256"},{"name":"memo","type":"bytes"}],"outputs":[{"internalType":"bool","name":"isAllowed","type":"bool"}]}]`
+const TestABI = `[{"type":"function","name":"receive","inputs":[{"name":"sender","type":"address"},{"name":"amount","type":"uint256"},{"name":"memo","type":"bytes"}],"outputs":[{"internalType":"bool","name":"isAllowed","type":"bool"}]}]`
 
 func TestUnpackInputIntoInterface(t *testing.T) {
-	abi, err := JSON(strings.NewReader(TEST_ABI))
+	abi, err := JSON(strings.NewReader(TestABI))
 	require.NoError(t, err)
 
 	type inputType struct {
@@ -35,7 +35,7 @@ func TestUnpackInputIntoInterface(t *testing.T) {
 	rawData, err := abi.Pack("receive", input.Sender, input.Amount, input.Memo)
 	require.NoError(t, err)
 
-	abi, err = JSON(strings.NewReader(TEST_ABI))
+	abi, err = JSON(strings.NewReader(TestABI))
 	require.NoError(t, err)
 
 	for _, test := range []struct {
@@ -97,7 +97,7 @@ func TestUnpackInputIntoInterface(t *testing.T) {
 }
 
 func TestPackOutput(t *testing.T) {
-	abi, err := JSON(strings.NewReader(TEST_ABI))
+	abi, err := JSON(strings.NewReader(TestABI))
 	require.NoError(t, err)
 
 	bytes, err := abi.PackOutput("receive", true)

cmd/simulator/load/loader.go

@@ -196,10 +196,8 @@ func ExecuteLoader(ctx context.Context, config config.Config) error {
 	log.Info("Distributed funds successfully", "time", time.Since(fundStart))
 
 	pks := make([]*ecdsa.PrivateKey, 0, len(keys))
-	senders := make([]common.Address, 0, len(keys))
 	for _, key := range keys {
 		pks = append(pks, key.PrivKey)
-		senders = append(senders, key.Address)
 	}
 
 	bigGwei := big.NewInt(params.GWei)

core/extstate/database.go

@@ -26,7 +26,7 @@ func wrapIfFirewood(db state.Database) state.Database {
 	if !ok {
 		return db
 	}
-	return &firewoodAccessorDb{
+	return &firewoodAccessorDB{
 		Database: db,
 		fw:       fw,
 	}

core/extstate/firewood_database.go

@@ -13,33 +13,33 @@ import (
 )
 
 var (
-	_ state.Database = (*firewoodAccessorDb)(nil)
+	_ state.Database = (*firewoodAccessorDB)(nil)
 	_ state.Trie     = (*firewood.AccountTrie)(nil)
 	_ state.Trie     = (*firewood.StorageTrie)(nil)
 )
 
-type firewoodAccessorDb struct {
+type firewoodAccessorDB struct {
 	state.Database
 	fw *firewood.Database
 }
 
 // OpenTrie opens the main account trie.
-func (db *firewoodAccessorDb) OpenTrie(root common.Hash) (state.Trie, error) {
+func (db *firewoodAccessorDB) OpenTrie(root common.Hash) (state.Trie, error) {
 	return firewood.NewAccountTrie(root, db.fw)
 }
 
 // OpenStorageTrie opens a wrapped version of the account trie.
-func (*firewoodAccessorDb) OpenStorageTrie(_ common.Hash, _ common.Address, accountRoot common.Hash, self state.Trie) (state.Trie, error) {
+func (*firewoodAccessorDB) OpenStorageTrie(_ common.Hash, _ common.Address, accountRoot common.Hash, self state.Trie) (state.Trie, error) {
 	accountTrie, ok := self.(*firewood.AccountTrie)
 	if !ok {
-		return nil, fmt.Errorf("Invalid account trie type: %T", self)
+		return nil, fmt.Errorf("invalid account trie type: %T", self)
 	}
 	return firewood.NewStorageTrie(accountTrie, accountRoot)
 }
 
 // CopyTrie returns a deep copy of the given trie.
 // It can be altered by the caller.
-func (*firewoodAccessorDb) CopyTrie(t state.Trie) state.Trie {
+func (*firewoodAccessorDB) CopyTrie(t state.Trie) state.Trie {
 	switch t := t.(type) {
 	case *firewood.AccountTrie:
 		return t.Copy()

interfaces/interfaces.go

@@ -14,8 +14,8 @@ import (
 	ethereum "github.com/ava-labs/libevm"
 )
 
-// NotFound is returned by API methods if the requested item does not exist.
-var NotFound = errors.New("not found")
+// ErrNotFound is returned by API methods if the requested item does not exist.
+var ErrNotFound = errors.New("not found")
 
 // Subscription represents an event subscription where events are
 // delivered on a data channel.

network/waiting_handler.go

@@ -49,12 +49,12 @@ func (w *waitingResponseHandler) OnFailure() error {
 	return nil
 }
 
-func (waitingHandler *waitingResponseHandler) WaitForResult(ctx context.Context) ([]byte, error) {
+func (w *waitingResponseHandler) WaitForResult(ctx context.Context) ([]byte, error) {
 	select {
 	case <-ctx.Done():
 		return nil, ctx.Err()
-	case response := <-waitingHandler.responseChan:
-		if waitingHandler.failed {
+	case response := <-w.responseChan:
+		if w.failed {
 			return nil, errRequestFailed
 		}
 		return response, nil

plugin/evm/atomic/state/atomic_trie_test.go

@@ -377,8 +377,6 @@ func TestIndexingNilShouldNotImpactTrie(t *testing.T) {
 			if err := indexAtomicTxs(a1, i, ops[i]); err != nil {
 				t.Fatal(err)
 			}
-		} else {
-			// do nothing
 		}
 	}
 

plugin/evm/atomic/sync/syncer.go

@@ -218,12 +218,12 @@ type syncerLeafTask struct {
 }
 
 func (a *syncerLeafTask) Start() []byte                  { return addZeroes(a.syncer.lastHeight + 1) }
-func (_ *syncerLeafTask) End() []byte                    { return nil }
-func (_ *syncerLeafTask) NodeType() message.NodeType     { return TrieNode }
+func (*syncerLeafTask) End() []byte                      { return nil }
+func (*syncerLeafTask) NodeType() message.NodeType       { return TrieNode }
 func (a *syncerLeafTask) OnFinish(context.Context) error { return a.syncer.onFinish() }
-func (_ *syncerLeafTask) OnStart() (bool, error)         { return false, nil }
+func (*syncerLeafTask) OnStart() (bool, error)           { return false, nil }
 func (a *syncerLeafTask) Root() common.Hash              { return a.syncer.targetRoot }
-func (_ *syncerLeafTask) Account() common.Hash           { return common.Hash{} }
+func (*syncerLeafTask) Account() common.Hash             { return common.Hash{} }
 func (a *syncerLeafTask) OnLeafs(keys, vals [][]byte) error {
 	return a.syncer.onLeafs(keys, vals)
 }

plugin/evm/atomic/tx.go

@@ -67,12 +67,12 @@ type EVMOutput struct {
 	AssetID ids.ID         `serialize:"true" json:"assetID"`
 }
 
-func (o EVMOutput) Compare(other EVMOutput) int {
-	addrComp := bytes.Compare(o.Address.Bytes(), other.Address.Bytes())
+func (out EVMOutput) Compare(other EVMOutput) int {
+	addrComp := bytes.Compare(out.Address.Bytes(), other.Address.Bytes())
 	if addrComp != 0 {
 		return addrComp
 	}
-	return bytes.Compare(o.AssetID[:], other.AssetID[:])
+	return bytes.Compare(out.AssetID[:], other.AssetID[:])
 }
 
 // EVMInput defines an input created from the EVM state to fund export transactions
@@ -83,12 +83,12 @@ type EVMInput struct {
 	Nonce   uint64         `serialize:"true" json:"nonce"`
 }
 
-func (i EVMInput) Compare(other EVMInput) int {
-	addrComp := bytes.Compare(i.Address.Bytes(), other.Address.Bytes())
+func (in EVMInput) Compare(other EVMInput) int {
+	addrComp := bytes.Compare(in.Address.Bytes(), other.Address.Bytes())
 	if addrComp != 0 {
 		return addrComp
 	}
-	return bytes.Compare(i.AssetID[:], other.AssetID[:])
+	return bytes.Compare(in.AssetID[:], other.AssetID[:])
 }
 
 // Verify ...