style: enable nilerr linter (#1182)

JonathanOppenheimer · ARR4N · web-flow · commit 9b32562bbe73 · 2025-09-04T21:04:54.000Z
Signed-off-by: Jonathan Oppenheimer &lt;147infiniti@gmail.com&gt;
Co-authored-by: Arran Schlosberg &lt;519948+ARR4N@users.noreply.github.com&gt;
diff --git a/.avalanche-golangci.yml b/.avalanche-golangci.yml
@@ -67,7 +67,7 @@ linters:
     - ineffassign
     - misspell
     - nakedret
-    # - nilerr
+    - nilerr
     - noctx
     - nolintlint
     - perfsprint
diff --git a/sync/statesync/trie_sync_tasks.go b/sync/statesync/trie_sync_tasks.go
@@ -117,7 +117,7 @@ func (s *storageTrieTask) OnStart() (bool, error) {
 	}
 	storageTrie, err := trie.New(trie.StorageTrieID(s.sync.root, s.root, firstAccount), s.sync.trieDB)
 	if err != nil {
-		return false, nil
+		return false, nil //nolint:nilerr // the storage trie does not exist, so it should be rerequested
 	}
 
 	// If the storage trie is already on disk, we only need to populate the storage snapshot for [accountHash]

Original file line number	Diff line number	Diff line change
`@@ -117,7 +117,7 @@ func (s *storageTrieTask) OnStart() (bool, error) {`
`117`	`117`	`}`
`118`	`118`	`storageTrie, err := trie.New(trie.StorageTrieID(s.sync.root, s.root, firstAccount), s.sync.trieDB)`
`119`	`119`	`if err != nil {`
`120`		`- return false, nil`
	`120`	`+ return false, nil //nolint:nilerr // the storage trie does not exist, so it should be rerequested`
`121`	`121`	`}`
`122`	`122`
`123`	`123`	`// If the storage trie is already on disk, we only need to populate the storage snapshot for [accountHash]`