fix: module resolution for cryptoassets #655
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gergelylovas
requested review from
neven-s,
atn4z7 and
adeamos83
as code owners
atn4z7
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Due to the lack of the export field support in the metro bundler, the build was failing when attempting to resolve a deep import from the module
@ledgerhq/cryptoassetsIssue report: facebook/metro#670
There is an RFC but it’s not fully working yet. In RN 0.72.0 it’s behind a feature flag: unstable_enablePackageExports. It will be released in 0.73.0 hopefully
react-native-community/discussions-and-proposals#534
Screenshots/Videos
Testing
Checklist for the author