Staging badges

[navillanueva]

No description provided.

[Copilot]

Pull request overview

This pull request implements a comprehensive badge system for the platform, introducing a new "staging badges" feature that enables badge assignment based on various requirements including academy courses, hackathon participation, and social interactions. The implementation uses a Strategy pattern for flexible badge assignment and includes UI components for displaying and managing badges across the platform.

Key Changes:

• Implemented a badge system with multiple assignment strategies (academy, project, social/requirement-based)
• Added UI components for displaying badges in 3D with interactive modals
• Integrated badge assignment workflows into authentication, course completion, and project management flows

Reviewed changes

Copilot reviewed 55 out of 57 changed files in this pull request and generated 9 comments.

Show a summary per file

File	Description
types/badge.ts	Refactored badge type definitions to support requirements-based badges and new status fields
server/services/badge.ts	Created core badge service with assignment logic for academy badges
server/services/badgeStrategy.ts	Implemented Strategy pattern for different badge assignment types
server/services/badgeAssignmentService.ts	Service layer coordinating badge assignment across strategies
server/services/socialBadge.ts	Implemented social badge assignment based on specific requirements
server/services/project-badge.ts	Implemented project-level badge assignment for hackathon projects
server/services/userBadge.ts	Service for retrieving user badges
server/services/rewardBoard.ts	Refactored reward board to support new badge structure
server/services/exportShowcase.ts	Added Excel export functionality for project showcase
components/profile/reward-board/	Complete redesign of badge display with 3D rendering using Three.js
components/showcase/	Enhanced showcase with badge display, assignment UI, and export features
lib/auth/authOptions.ts	Integrated badge assignment into GitHub authentication flow
app/api/badge/	New API routes for badge operations (assign, validate, get)
package.json	Added dependencies for 3D rendering and Excel generation

Comments suppressed due to low confidence (1)

server/services/inviteProjectMember.ts:1

• The findFirst query only filters by email and project_id, but if an invitedUser exists with a user_id, there could be a race condition where two members exist: one with just email and another with user_id. The query should also check for user_id when invitedUser is present: where: { OR: [{ email, project_id: projectId }, ...(invitedUser ? [{ user_id: invitedUser.id, project_id: projectId }] : [])] }

import { prisma } from "@/prisma/prisma";

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Function declares a return type but never returns a value. The function also accepts a userId parameter but doesn't use it in the query, which will return an arbitrary register form instead of the one for the specified user. Add a where clause using the userId parameter and return the result.

Suggested change

	const registerForm = await prisma.registerForm.findFirst({})
	const registerForm = await prisma.registerForm.findFirst({
	where: { userId }
	});
	return registerForm;

[Copilot]

Empty catch block silently swallows errors. At minimum, log the caught error to help with debugging: catch (parseError) { console.error('Failed to parse error response:', parseError); errorMessage = '...' }

Suggested change

	} catch {
	} catch (parseError) {
	console.error('Failed to parse error response:', parseError);

[Copilot]

Missing error handling for the axios request. Wrap the request in a try-catch block to handle potential network errors or API failures gracefully.

Suggested change

	const response = await axios.get("/api/badge/get-all");
	const filteredBadges = response.data.filter(
	(badge: Badge) => badge.category == "hackathon"
	);
	setOptionsWithLabel(
	filteredBadges.map((option: Badge) => ({
	label: option.name,
	value: option.id,
	}))
	);
	try {
	const response = await axios.get("/api/badge/get-all");
	const filteredBadges = response.data.filter(
	(badge: Badge) => badge.category == "hackathon"
	);
	setOptionsWithLabel(
	filteredBadges.map((option: Badge) => ({
	label: option.name,
	value: option.id,
	}))
	);
	} catch (error) {
	toast({
	title: "Failed to fetch badges",
	description: "An error occurred while fetching badges.",
	variant: "destructive",
	duration: 3000,
	});
	}

[Copilot]

Variable mismatch: catching err but logging error. Should be console.error('Error exporting:', err);

Suggested change

	console.error('Error exporting:', error);
	toast({
	title: "Error exporting projects",
	description: error,
	console.error('Error exporting:', err);
	toast({
	title: "Error exporting projects",
	description: String(err),

[Copilot]

Unused import. The set function from date-fns is imported but never used in this file. Remove this import.

Suggested change

import { set } from "date-fns";

[Copilot]

The component doesn't handle the case where searchParams.hackathon is undefined or an array. This could cause the UserNotRegistered component to receive an invalid hackathonId. Add validation: const hackathonId = typeof searchParams.hackathon === 'string' ? searchParams.hackathon : ''; if (!hackathonId) { return <Error />; }

[Copilot]

[nitpick] Arrow function missing explicit return statement. For clarity, use explicit return: .sort((element) => (element.is_unlocked ? -1 : 1))

Suggested change

	}).sort(element=>element.is_unlocked ? -1 : 1);
	}).sort(element => { return element.is_unlocked ? -1 : 1; });

[Copilot]

Setting modal state before navigation is problematic because the redirect happens immediately. The modal may not render before the navigation occurs. Consider using router events or moving the redirect inside the modal's continue handler.

[Copilot]

Missing null/undefined check for custom_attributes. If session.user.custom_attributes is undefined, calling .includes() will throw a TypeError. Add a safe check: const hasRole = session?.user.custom_attributes?.includes(role) ?? false