Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move relayer main package and related configs to it's own subfolder #409

Closed
2 of 4 tasks
iansuvak opened this issue Aug 2, 2024 · 0 comments · Fixed by #411
Closed
2 of 4 tasks

Move relayer main package and related configs to it's own subfolder #409

iansuvak opened this issue Aug 2, 2024 · 0 comments · Fixed by #411
Assignees
Labels
enhancement New feature or request Warp Signature API API service for serving arbitrary Warp signatures from any VM

Comments

@iansuvak
Copy link
Contributor

iansuvak commented Aug 2, 2024

Context and scope
After #368 is merged we should do some clean up and move relayer specific main, api and config packages and to the relayer subfolder.

TODOs before merging

  • Reorganize configs such that we can explicitly confirm that relayer config and signature aggregator config both implement peers.Config interfaces.
  • Extract duplicative e2e test functionality for running a binary into a helper function that both applications use.
  • Re-evaluate locations of scripts, build and testing
  • Re-evaluate passing configs around by reference

Discussion and alternatives

Open questions

  • Should we consider renaming the repo at this point? To what?
@iansuvak iansuvak added enhancement New feature or request Warp Signature API API service for serving arbitrary Warp signatures from any VM labels Aug 2, 2024
@iansuvak iansuvak self-assigned this Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Warp Signature API API service for serving arbitrary Warp signatures from any VM
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant