From 503992a32b8960bcef7ae6505f940f1d5f571ce2 Mon Sep 17 00:00:00 2001 From: "F. Eugene Aumson" Date: Thu, 22 Aug 2024 14:30:39 +0000 Subject: [PATCH] store metric as a percentage, not a ratio addresses review comment https://github.com/ava-labs/awm-relayer/pull/434#discussion_r1725755996 --- signature-aggregator/aggregator/aggregator.go | 2 +- tests/signature_aggregator_api.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/signature-aggregator/aggregator/aggregator.go b/signature-aggregator/aggregator/aggregator.go index 0e6cf3df..7a0f441d 100644 --- a/signature-aggregator/aggregator/aggregator.go +++ b/signature-aggregator/aggregator/aggregator.go @@ -125,7 +125,7 @@ func (s *SignatureAggregator) CreateSignedMessage( signingSubnet.String(), ).Set( float64(connectedValidators.ConnectedWeight) / - float64(connectedValidators.TotalValidatorWeight), + float64(connectedValidators.TotalValidatorWeight) * 100, ) if !utils.CheckStakeWeightPercentageExceedsThreshold( diff --git a/tests/signature_aggregator_api.go b/tests/signature_aggregator_api.go index 64979577..ce3daac5 100644 --- a/tests/signature_aggregator_api.go +++ b/tests/signature_aggregator_api.go @@ -138,7 +138,7 @@ func SignatureAggregatorAPI(network interfaces.LocalNetwork) { subnetAInfo.SubnetID.String(), ), "==", - 1, + 100, }, } { Expect(metricsSample[m.name]).Should(