[nix] Update to 25.05 #4050
Merged
[nix] Update to 25.05 #4050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maru-ava
commented
Jul 2, 2025
Taskfile.yml
Outdated
| E2E_SERIAL: 1 | ||
| cmds: | ||
| - task: test-e2e-kube | ||
| - cmd: bash -x ./scripts/tests.e2e.kube.sh {{.CLI_ARGS}} |
There was a problem hiding this comment.
I noticed this needed to be changed when the job flaked in CI on this PR. Our e2e jobs can't be reliably run in parallel on github action runners, and E2E_SERIAL is how we ensure serial execution. But since tasks don't inherit the environment of a calling task, this wasn't previously configured correctly. Calling the script directly ensures that E2E_SERIAL will be respected.
Elvis339
approved these changes
Jul 3, 2025
StephenButtolph
approved these changes
Jul 3, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
A given nix release only receives security updates for 7 months, and though security updates aren't critical for our tooling, there's no reason not to upgrade regularly. https://nixos.org/blog/announcements/2025/nixos-2505/
|
Updated to limit the scope of the e2e-kube job to just xsvm (to ensure subnet coverage) to avoid the flakiness caused by the resource-constrained github runners. In any case, the kube job is now disabled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
A given nix release only receives security updates for 7 months, and though security updates aren't critical for our tooling, there's no reason not to upgrade regularly.
https://nixos.org/blog/announcements/2025/nixos-2505/
How this was tested
CI
Need to be documented in RELEASES.md?
N/A