Skip to content

Conversation

joshua-kim
Copy link
Contributor

Why this should be merged

Allows clients to discover the service definition + request/response types without knowing the proto file

How this works

Registers the xsvm grpc server into the grpc reflection api. Clients who don't know the proto file (postman, grpcurl) can query the reflection api to discover the available grpc services + its types to be able to communicate with the server without having the proto definition.

How this was tested

Tested manually

➜  avalanchego git:(xsvm-server-reflection) ✗ grpcurl -H 'chain-id: Q3fReCSX3QSXxGXkcFC4wyU4ZmPsc22HAGjoge8oxWCzQ8bQD' -d '{"message": "foo"}' -plaintext 127.0.0.1:9650 xsvm.Ping/Ping

{
  "message": "foo"
}

Need to be documented in RELEASES.md?

No

Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
@joshua-kim joshua-kim requested a review from mpignatelli12 June 11, 2025 21:17
@joshua-kim joshua-kim self-assigned this Jun 11, 2025
@joshua-kim joshua-kim moved this to In Progress 🏗️ in avalanchego Jun 11, 2025
@StephenButtolph StephenButtolph added this pull request to the merge queue Jun 12, 2025
Merged via the queue into master with commit 1ab92d3 Jun 12, 2025
28 checks passed
@StephenButtolph StephenButtolph deleted the xsvm-server-reflection branch June 12, 2025 15:45
@github-project-automation github-project-automation bot moved this from In Progress 🏗️ to Done 🎉 in avalanchego Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants