Use IPv4 addresses if possible #3812
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-kim
approved these changes
Mar 18, 2025
maru-ava
approved these changes
Mar 18, 2025
|
Will merge after the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Saves 12 bytes per IP!
How this works
On the receiving side of these IPs, we already handle IPv4 addresses. However for compatibility reasons, we only send IPv6 addresses currently. This is no longer required (as of Etna activation). So we can save the 12 bytes.
How this was tested
The e2e upgrade test verifies that this is backwards compatible.
Need to be documented in RELEASES.md?