Comment on the need for CGO_ENABLED=1 to support cross-compilation
#3735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronbuchwald
approved these changes
Feb 21, 2025
yacovm
approved these changes
Feb 21, 2025
richardpringle
pushed a commit
that referenced
this pull request
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While ensuring testing of multi-arch image build for hypersdk, time was spent trying to figure out a cross-compilation error that turned out to be due to
CGO_ENABLED=1not being set. A literal reading of the comment removed in this PR did not suggest the importance ofCGO_ENABLED=1to cross-compilation. Accordingly, this PR adds a new comment indicating thatCGO_ENABLED=1is required when cross-compiling.