-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] Migrate from buf-*-action to buf-action #3639
Conversation
6e7d4d4
to
233d1a9
Compare
with: | ||
input: "proto" | ||
buf_token: ${{ secrets.BUF_TOKEN }} | ||
token: ${{ secrets.BUF_TOKEN }} | ||
version: 1.35.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the minimum version required by the new action. The action will refuse to run with v1.31.0.
9898554
to
adcaeeb
Compare
with: | ||
input: "proto" | ||
github_token: ${{ github.token }} | ||
pr_comment: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The job will need the pull-requests: write
permission if we want to enable pr comments.
.github/workflows/ci.yml
Outdated
with: | ||
input: "proto" | ||
github_token: ${{ github.token }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit do you actually need to specify this? I thought it was automatically set 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
The `buf-*-action` family of actions have been deprecated in favor of buf-action.
Why this should be merged
The
buf-*-action
family of actions have been deprecated in favor of buf-action.How this works
Migrates to buf-action as per the migration guide.
How this was tested
CI
Need to be documented in RELEASES.md?
N/A