Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Migrate from buf-*-action to buf-action #3639

Merged
merged 2 commits into from
Jan 8, 2025
Merged

Conversation

marun
Copy link
Contributor

@marun marun commented Jan 6, 2025

Why this should be merged

The buf-*-action family of actions have been deprecated in favor of buf-action.

How this works

Migrates to buf-action as per the migration guide.

How this was tested

CI

Need to be documented in RELEASES.md?

N/A

@marun marun added the ci This focuses on changes to the CI process label Jan 6, 2025
@marun marun self-assigned this Jan 6, 2025
@marun marun force-pushed the buf-action branch 5 times, most recently from 6e7d4d4 to 233d1a9 Compare January 7, 2025 02:22
with:
input: "proto"
buf_token: ${{ secrets.BUF_TOKEN }}
token: ${{ secrets.BUF_TOKEN }}
version: 1.35.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the minimum version required by the new action. The action will refuse to run with v1.31.0.

@marun marun force-pushed the buf-action branch 2 times, most recently from 9898554 to adcaeeb Compare January 7, 2025 02:37
with:
input: "proto"
github_token: ${{ github.token }}
pr_comment: false
Copy link
Contributor Author

@marun marun Jan 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The job will need the pull-requests: write permission if we want to enable pr comments.

@marun marun marked this pull request as ready for review January 7, 2025 02:47
with:
input: "proto"
github_token: ${{ github.token }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit do you actually need to specify this? I thought it was automatically set 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

The `buf-*-action` family of actions have been deprecated in favor of
buf-action.
@StephenButtolph StephenButtolph added this pull request to the merge queue Jan 8, 2025
Merged via the queue into master with commit 18b8320 Jan 8, 2025
22 checks passed
@StephenButtolph StephenButtolph deleted the buf-action branch January 8, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci This focuses on changes to the CI process
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants