Log error if database returns unsorted heights #2670
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenButtolph
added
monitoring
StephenButtolph
requested review from
abi87,
danlaine and
dhrubabasu
as code owners
abi87
approved these changes
Jan 26, 2024
joshua-kim
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
If triggered, this log would quickly identify that a critical invariant has been broken.
How this works
ApplyValidatorWeightDiffsiterates backwards through the disk applying weight diffs. If the weight diffs were returned out of order, the termination condition wouldn't work properly. This will loudly announce this failure to the node operator.How this was tested
N/A