tmpnet: Save metrics snapshot to disk before node shutdown
#2601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenButtolph
approved these changes
Jan 11, 2024
Contributor
StephenButtolph
left a comment
StephenButtolph
left a comment
There was a problem hiding this comment.
Awesome! Thanks for such a quick turnaround!
abi87
approved these changes
Jan 11, 2024
marun
pushed a commit
that referenced
this pull request
Jan 17, 2024
chand1012
pushed a commit
to multisig-labs/avalanchego
that referenced
this pull request
Oct 1, 2024
Co-authored-by: David Boehm <91908103+dboehm-avalabs@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
As per a request from @StephenButtolph
How this works
Whenever node shutdown is initiated, retrieves
/ext/metricsand writes it to the[data dir]/metrics/[timestamp].How this was tested
Locally started and stopped a network, checked
~/.tmpnet/networks/latest/[node id]/metricsfor a timestamped metrics snapshot.