Verify SignedIP.Timestamp from PeerList messages
#2587
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danlaine
commented
Jan 4, 2024
| cert, | ||
| ip.UnsignedIP.bytes(), | ||
| ip.Signature, | ||
| ) | ||
| ); err != nil { | ||
| return fmt.Errorf("%w: %w", errInvalidSignature, err) |
There was a problem hiding this comment.
Changed to make test assertions possible
danlaine
commented
Jan 4, 2024
| // Note that it is expected that the [ipSigningTime] can be in the past. We | ||
| // are just verifying that the claimed signing time isn't too far in the | ||
| // future here. | ||
| if float64(msg.IpSigningTime)-float64(myTime) > p.MaxClockDifference.Seconds() { |
added 7 commits
January 4, 2024 16:45
…nchego into move-peer-timestamp-check
StephenButtolph
added
networking
StephenButtolph
approved these changes
Jan 18, 2024
…nchego into move-peer-timestamp-check
StephenButtolph
changed the title
SignedIP.Timestamp from PeerList messages
dhrubabasu
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Currently signed IP timestamps aren't verified to be reasonable upon receipt of a peerlist. This is an unusual discrepancy compared to the handling during the
Handshakemessage. This check was intended to prevent a validator from accidentally signing an invalid IP with an unreasonable timestamp and then being unable to connect to the network forever.How this works
Move check that a (prospective) peer's timestamp on their signature isn't too far in the future to
SignedIP.VerifyHow this was tested
New UT.