Skip to content

Remove stale TODO #2468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 12, 2023
Merged

Remove stale TODO #2468

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
88e2ef4
remove old TODO
Dec 11, 2023
fd8bbed
Merge branch 'dev' into merkledb-comment
Dec 11, 2023
bee546c
Merge branch 'dev' into merkledb-comment
Dec 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions x/merkledb/history.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,10 +98,6 @@ func (th *trieHistory) getValueChanges(
}

// [endRootChanges] is the last change in the history resulting in [endRoot].
// TODO when we update to minimum go version 1.20.X, make this return another
// wrapped error ErrNoEndRoot. In NetworkServer.HandleChangeProofRequest, if we return
// that error, we know we shouldn't try to generate a range proof since we
// lack the necessary history.
endRootChanges, ok := th.lastChanges[endRoot]
if !ok {
return nil, fmt.Errorf("%w: %s", ErrNoEndRoot, endRoot)
Expand Down