Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove build check from unit tests #2189

Merged
merged 2 commits into from
Oct 18, 2023
Merged

Conversation

StephenButtolph
Copy link
Contributor

Why this should be merged

# Check to see if the build script creates any unstaged changes to prevent
# regression where builds go.mod/go.sum files get out of date.
if [[ -z $(git status -s) ]]; then
    echo "Build script created unstaged changes in the repository"
    # TODO: Revise this check once we can reliably build without changes
    # exit 1
fi

-z is used to test that the output is empty. So this check was completely backwards. Additionally, we now have a dedicated test for this as part of the auto-generated code check.

How this works

Simplifies the unit test flow by replacing the call to build_and_test.sh with build_test.sh

How this was tested

CI

@StephenButtolph StephenButtolph merged commit cd65240 into dev Oct 18, 2023
@StephenButtolph StephenButtolph deleted the remove-build-and-test branch October 18, 2023 20:24
@StephenButtolph StephenButtolph added this to the v1.10.14 milestone Oct 18, 2023
@StephenButtolph StephenButtolph added bug Something isn't working ci This focuses on changes to the CI process labels Oct 18, 2023
@StephenButtolph StephenButtolph self-assigned this Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci This focuses on changes to the CI process
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant